Skip to content

Allow fetching the Cloud ICE servers #157774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
balloob merged 4 commits into from
Dec 2, 2025
Merged

Allow fetching the Cloud ICE servers #157774

balloob merged 4 commits into from
Dec 2, 2025

Conversation

@balloob
Copy link
Member

@balloob balloob commented Dec 2, 2025 •
edited
Loading

Breaking change

Proposed change

Allow fetching the Cloud ICE servers for Music Assistant integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 2, 2025 19:52
@home-assistant
Copy link

home-assistant bot commented Dec 2, 2025

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 2, 2025

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@balloob balloob added this to the 2025.12.0 milestone Dec 2, 2025
Copilot AI reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functionality to expose Cloud ICE (Interactive Connectivity Establishment) servers through a websocket API endpoint for use by the Music Assistant integration. The implementation stores ICE servers from the cloud service and provides a simple websocket command to retrieve them.

Key Changes

  • Adds ice_servers property to the CloudClient to expose stored ICE servers
  • Implements a new websocket command cloud/webrtc/ice_servers to fetch ICE servers
  • Refactors ICE server registration to store servers in the client instance

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
homeassistant/components/cloud/client.py Adds _ice_servers instance variable and ice_servers property; refactors register_cloud_ice_server to store ICE servers in the client instance instead of using a closure
homeassistant/components/cloud/http_api.py Registers and implements new websocket command cloud/webrtc/ice_servers to return ICE servers as dictionaries
tests/components/cloud/test_http_api.py Adds test for the new websocket command verifying it returns correctly formatted ICE server data

@zweckj
Copy link
Member

zweckj commented Dec 2, 2025

Why are we adding new_features that late in the beta to the milestone?

@marcelveldt marcelveldt mentioned this pull request Dec 2, 2025
Merged
@balloob
Copy link
Member Author

balloob commented Dec 2, 2025

It's to unblock a feature for Music Assistant, which does their big quarterly release 2.7 in 2 weeks. It's not technically a feature, it extends the API interface to fetch some data.

frenck
frenck reviewed Dec 2, 2025
View reviewed changes
@balloob balloob merged commit e857abb into dev Dec 2, 2025
61 of 62 checks passed
@balloob balloob deleted the cloud-ice branch December 2, 2025 21:02
frenck pushed a commit that referenced this pull request Dec 2, 2025
@balloob @frenck
Allow fetching the Cloud ICE servers (#157774)
c7f1729
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

@klejejs klejejs klejejs approved these changes

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed core has-tests integration: cloud new-feature Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@balloob @zweckj @frenck @klejejs