Skip to content

Conversation

@vingerha
Copy link
Contributor

@vingerha vingerha commented Dec 1, 2025

MF introduced again a new state: "Brouillard dense givrant"

Proposed change

New mapping from Meteo France

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

MF introduced again a new state: "Brouillard dense givrant"
@home-assistant
Copy link

home-assistant bot commented Dec 1, 2025

Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (meteo_france) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of meteo_france can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign meteo_france Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I wish we had better unit tests and coverage of meteo_france
Amaybe someone feels like adding snapshot tests?

@vingerha
Copy link
Contributor Author

vingerha commented Dec 2, 2025

LGTM 👍

I wish we had better unit tests and coverage of meteo_france Amaybe someone feels like adding snapshot tests?

Can you please elaborate? A couple PR's I entered were required due to MF (through the MF api) providing a state that is not covered ... Sadly, as long as MF does not provide a comprehensive list of states (no answer on any request), no test will help preventing this (!) type of PR

@epenet epenet added this to the 2025.12.0 milestone Dec 2, 2025
@epenet epenet merged commit e002664 into home-assistant:dev Dec 2, 2025
36 checks passed
@epenet
Copy link
Contributor

epenet commented Dec 2, 2025

LGTM 👍
I wish we had better unit tests and coverage of meteo_france Amaybe someone feels like adding snapshot tests?

Can you please elaborate? A couple PR's I entered were required due to MF (through the MF api) providing a state that is not covered ... Sadly, as long as MF does not provide a comprehensive list of states (no answer on any request), no test will help preventing this (!) type of PR

Yeah I know - but that doesn't mean coverage can't be improved :)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants