Skip to content

Bump python-roborock to 3.8.4 #157538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thecode merged 1 commit into from
Nov 29, 2025
Merged

Bump python-roborock to 3.8.4 #157538

thecode merged 1 commit into from
Nov 29, 2025

Conversation

@allenporter
Copy link
Contributor

@allenporter allenporter commented Nov 29, 2025

Proposed change

Bump python-roborock to 3.8.4
Release notes:
Changes: Python-roborock/python-roborock@v3.8.3...v3.8.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings November 29, 2025 16:28
@home-assistant
Copy link

home-assistant bot commented Nov 29, 2025

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@allenporter allenporter added this to the 2025.12.0 milestone Nov 29, 2025
Copilot AI reviewed Nov 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the python-roborock dependency from version 3.8.3 to 3.8.4 to address two reported bugs. This is a minor patch release that includes bug fixes without any breaking changes.

Key changes:

  • Updated python-roborock dependency to version 3.8.4 across all requirement files
  • No code changes required in the roborock integration itself

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_all.txt Updated python-roborock from 3.8.3 to 3.8.4
requirements_test_all.txt Updated python-roborock from 3.8.3 to 3.8.4
homeassistant/components/roborock/manifest.json Updated python-roborock from 3.8.3 to 3.8.4

@thecode thecode merged commit d5be623 into home-assistant:dev Nov 29, 2025
73 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@thecode thecode thecode approved these changes

+1 more reviewer

@Lash-L Lash-L Lash-L approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed dependency integration: roborock Quality Scale: silver small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.12.0

Development

Successfully merging this pull request may close these issues.

Roborock vacuums lose connection and become unavailable overnight Roborock config error causing Home Assistant to crash in 2025.12 beta

4 participants

@allenporter @thecode @Lash-L @frenck