Remove name from Shelly RGBCCT sensors
#157492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
thecode
approved these changes
Nov 28, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit name field from two Shelly RGBCCT sensor descriptions (power_rgbcct and energy_rgbcct), allowing Home Assistant's entity name translation system to automatically generate names based on the device class.
Key changes:
- Removed hardcoded "Power" and "Energy" names from RGBCCT sensor descriptions
- Added comprehensive test coverage to verify the new behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/shelly/sensor.py | Removed name field from power_rgbcct and energy_rgbcct sensor descriptions, aligning them with other similar light component sensors (cct, rgb, rgbw) that rely on device class for automatic naming |
| tests/components/shelly/test_sensor.py | Added test to verify that RGBCCT sensors correctly have None for both name and translation_key fields, confirming proper entity naming behavior |
frenck
pushed a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Once entity name translations are implemented, the name should not be returned.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: