-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Bump universal-silabs-flasher to v0.1.0 #156291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump universal-silabs-flasher to v0.1.0 #156291
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the universal-silabs-flasher dependency from version 0.0.37 to 0.1.0, which introduces a new API for more efficient firmware probing and flashing. The key changes include:
- Updated API now requires both
bootloader_reset_methodsandapplication_probe_methodsparameters - Changed from instance variables to class variables (
BOOTLOADER_RESET_METHODSandAPPLICATION_PROBE_METHODS) - Optimized firmware probing to use device-specific configurations
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| requirements_all.txt | Updated universal-silabs-flasher dependency to v0.1.0 |
| requirements_test_all.txt | Updated universal-silabs-flasher dependency to v0.1.0 |
| homeassistant/components/homeassistant_hardware/manifest.json | Updated universal-silabs-flasher requirement to v0.1.0 |
| homeassistant/components/homeassistant_hardware/util.py | Updated API calls to include new required parameters for bootloader reset and application probe methods; contains a type conversion bug on line 417 |
| homeassistant/components/homeassistant_hardware/update.py | Changed from instance variable to class variables for reset/probe methods |
| homeassistant/components/homeassistant_hardware/firmware_config_flow.py | Added APPLICATION_PROBE_METHODS class variable and updated probe calls |
| homeassistant/components/homeassistant_sky_connect/config_flow.py | Added device-specific bootloader reset and application probe method configurations |
| homeassistant/components/homeassistant_sky_connect/update.py | Updated to reference mixin class variables instead of direct assignment |
| homeassistant/components/homeassistant_yellow/config_flow.py | Added device-specific bootloader reset and application probe method configurations |
| homeassistant/components/homeassistant_yellow/update.py | Updated to reference mixin class variables instead of direct assignment |
| homeassistant/components/homeassistant_connect_zbt2/config_flow.py | Added device-specific bootloader reset and application probe methods including both RTS_DTR and BAUDRATE |
| homeassistant/components/homeassistant_connect_zbt2/update.py | Updated to reference mixin class variables instead of direct assignment |
| homeassistant/components/zha/repairs/wrong_silabs_firmware.py | Updated probe_silabs_firmware_type call with new required parameters |
| tests/components/homeassistant_hardware/test_util.py | Updated test calls to include new parameters |
| tests/components/homeassistant_hardware/test_update.py | Updated mock entity to use class variables and added application_probe_methods to mock function signatures |
| tests/components/homeassistant_hardware/test_config_flow.py | Added application_probe_methods parameter to mock function signature |
| tests/components/homeassistant_connect_zbt2/test_config_flow.py | Updated test assertion to expect both RTS_DTR and BAUDRATE reset methods |
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @puddly 👍
Co-authored-by: TheJulianJES <[email protected]>
TheJulianJES
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Did a quick test run with ZBT-2 as well and had no issues.
One small question:
Proposed change
Bump universal-silabs-flasher from 0.0.37 to 0.1.0. This release improves communication with OpenThread RCP firmware and provides a new API to speed up probing during firmware flashing. Our approach is now:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: