Fix set_absolute_position angle #156185
Merged
Fix set_absolute_position angle #156185
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the tilt angle calculation in the async_set_absolute_position method for Motion Blinds. The change inverts the angle value to align with the coordinate system used by the Motion Blinds API, making it consistent with other tilt position methods in the integration.
Key Changes
- Added angle inversion (
angle = 180 - angle) after converting from 0-100 range to 0-180 degrees - This aligns with the existing pattern used in
async_set_cover_tilt_positionand other tilt-related methods
Comments suppressed due to low confidence (1)
homeassistant/components/motion_blinds/cover.py:249
- The
async_set_absolute_positionmethod with tilt angle parameter lacks test coverage. Since other similar methods likeasync_set_cover_tilt_positionhave test coverage in the integration (and similar tilt transformations exist in lines 304-306 and 383-406), this new angle inversion logic should be tested to verify the correct transformation from Home Assistant's 0-100 range to the Motion Blinds API's 0-180 range.
angle = kwargs.get(ATTR_TILT_POSITION)
if angle is not None:
angle = angle * 180 / 100
angle = 180 - angle
async with self._api_lock:
await self.hass.async_add_executor_job(
self._blind.Set_position,
100 - position,
angle,
self._restore_tilt,
)
zweckj
reviewed
Nov 9, 2025
Member
zweckj
left a comment
There was a problem hiding this comment.
Should we add a test to guard against future regression?
Contributor
Author
|
@zweckj I don't have test coverage for the motion_blinds integration besides the required config flow. I should at some point add tests in general, but there are many things I should be doing... |
zweckj
approved these changes
Nov 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
In HA 2025.11.0 the angle for HomeAssistant tilt devices was reverted 0>100, 100>0.
But in one specific function this inversion was forgotten leading to misbehaviour.
(you set it to 25, but it goes to 75 and then shows position 75)
see #149777
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: