Skip to content

Add firmware flashing debug loggers to hardware integrations #156480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MartinHjelmare merged 4 commits into from
Nov 13, 2025
Merged

Add firmware flashing debug loggers to hardware integrations #156480

MartinHjelmare merged 4 commits into from
Nov 13, 2025
+18 −0

Conversation

@puddly
Copy link
Contributor

@puddly puddly commented Nov 12, 2025

Proposed change

The hardware integrations currently use a few different packages when flashing adapter firmware. This PR enables logging for all of them, giving us full context for when firmware flashing fails.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@puddly puddly added this to the 2025.11.2 milestone Nov 12, 2025
@home-assistant
Copy link

home-assistant bot commented Nov 12, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_yellow) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_yellow can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_yellow Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 12, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_connect_zbt2) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_connect_zbt2 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_connect_zbt2 Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 12, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_sky_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_sky_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_sky_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

TheJulianJES
TheJulianJES reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good

MartinHjelmare and others added 3 commits November 13, 2025 09:14
@MartinHjelmare @TheJulianJES
Adjust package name
72b30fe 
Co-authored-by: TheJulianJES <[email protected]>
@MartinHjelmare @TheJulianJES
Adjust package name
7be1cbb 
Co-authored-by: TheJulianJES <[email protected]>
@MartinHjelmare @TheJulianJES
Adjust package name
d2e9702 
Co-authored-by: TheJulianJES <[email protected]>
@MartinHjelmare MartinHjelmare marked this pull request as ready for review November 13, 2025 08:15
Copilot AI review requested due to automatic review settings November 13, 2025 08:15
@MartinHjelmare MartinHjelmare requested a review from a team as a code owner November 13, 2025 08:15
Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds firmware flashing debug loggers to three Home Assistant hardware integrations to improve diagnostics when firmware flashing operations fail. The loggers enable debug-level logging for the underlying packages that handle Silabs adapter firmware flashing.

  • Adds identical logger configuration to three hardware integrations
  • Enables logging for firmware flashing packages: bellows, universal_silabs_flasher, zigpy.serial, and serial_asyncio_fast
  • Provides better diagnostic context for firmware flashing failures

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/homeassistant_yellow/manifest.json Added loggers array with 4 firmware flashing package names
homeassistant/components/homeassistant_sky_connect/manifest.json Added loggers array with 4 firmware flashing package names
homeassistant/components/homeassistant_connect_zbt2/manifest.json Added loggers array with 4 firmware flashing package names

@MartinHjelmare MartinHjelmare merged commit 35c6113 into home-assistant:dev Nov 13, 2025
46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TheJulianJES TheJulianJES TheJulianJES left review comments

Copilot code review Copilot Copilot left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

bugfix cherry-picked cla-signed integration: homeassistant_connect_zbt2 integration: homeassistant_sky_connect integration: homeassistant_yellow Quality Scale: bronze Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.11.2

Development

Successfully merging this pull request may close these issues.

4 participants

@puddly @MartinHjelmare @TheJulianJES @frenck