Skip to content

Conversation

@MichaelMKKelly
Copy link
Contributor

Proposed change

Move URL out of System Bridge strings.json to avoid making it translatable

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (system_bridge) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of system_bridge can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign system_bridge Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MichaelMKKelly MichaelMKKelly changed the title moved non-translatable URL out of strings.json for system_bridge move URL out of system_bridge strings.json Oct 24, 2025
@MichaelMKKelly MichaelMKKelly changed the title move URL out of system_bridge strings.json Move URL out of system_bridge strings.json Oct 24, 2025
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to make a const out of this so any potential future update doesn't require changes on 3 places.

@home-assistant home-assistant bot marked this pull request as draft October 24, 2025 07:11
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make a constant of the URL, since you use it on multiple places. :)

@erwindouna
Copy link
Contributor

@CoMPaTech already beat me. :p

@MichaelMKKelly MichaelMKKelly marked this pull request as ready for review October 24, 2025 09:02
Copy link
Contributor

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@timmo001 timmo001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelMKKelly 👍

@joostlek joostlek merged commit 80c06c6 into home-assistant:dev Oct 24, 2025
36 checks passed
@joostlek joostlek added this to the 2025.10.4 milestone Oct 24, 2025
@frenck frenck mentioned this pull request Oct 24, 2025
@MichaelMKKelly MichaelMKKelly deleted the move-strings branch October 24, 2025 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants