Skip to content

update methods to non deprecated methods in vesync #155887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 2 commits into from
Nov 8, 2025
Merged

update methods to non deprecated methods in vesync #155887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e49668a
switch away from deprecated method
cdnninja Nov 6, 2025
e523998
Tests
cdnninja Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/vesync/humidifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ async def async_set_mode(self, mode: str) -> None:
raise HomeAssistantError(
f"Invalid mode {mode}. Available modes: {self.available_modes}"
)
if not await self.device.set_humidity_mode(self._get_vs_mode(mode)):
if not await self.device.set_mode(self._get_vs_mode(mode)):
raise HomeAssistantError(self.device.last_response.message)

if mode == MODE_SLEEP:
Expand Down
4 changes: 2 additions & 2 deletions tests/components/vesync/test_humidifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ async def test_set_mode_invalid(
"""Test handling of invalid value in set_mode method."""

with patch(
"pyvesync.devices.vesynchumidifier.VeSyncHumid200300S.set_humidity_mode"
"pyvesync.devices.vesynchumidifier.VeSyncHumid200300S.set_mode"
) as method_mock:
with pytest.raises(HomeAssistantError):
await hass.services.async_call(
Expand Down Expand Up @@ -268,7 +268,7 @@ async def test_set_mode(
with (
expectation,
patch(
"pyvesync.devices.vesynchumidifier.VeSyncHumid200300S.set_humidity_mode",
"pyvesync.devices.vesynchumidifier.VeSyncHumid200300S.set_mode",
return_value=api_response,
) as method_mock,
):
Expand Down
Loading