Skip to content

Add Konnected brand #153280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

Add Konnected brand #153280

merged 2 commits into from
Sep 30, 2025

Conversation

@joostlek
Copy link
Member

@joostlek joostlek commented Sep 30, 2025 •
edited
Loading

Proposed change

Add Konnected brand

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.10.0 milestone Sep 30, 2025
Copilot AI review requested due to automatic review settings September 30, 2025 18:03
Copilot AI reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new virtual integration for Konnected ESPHome support and creates a brand definition to group related Konnected integrations together.

  • Adds a new virtual integration konnected_esphome that is supported by ESPHome
  • Creates a brand configuration for Konnected to group both konnected and konnected_esphome integrations

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/konnected_esphome/manifest.json Creates virtual integration manifest for Konnected ESPHome support
homeassistant/components/konnected_esphome/init.py Adds minimal init file with integration description
homeassistant/brands/konnected.json Defines Konnected brand to group related integrations

homeassistant/components/konnected_esphome/manifest.json
"domain": "konnected_esphome",
"name": "Konnected",
"integration_type": "virtual",
"supported_by": "esphome"
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest is missing required fields for Home Assistant integrations. Add the mandatory codeowners, documentation, and requirements fields. For virtual integrations, codeowners should reference the maintainers of the supporting integration (ESPHome in this case).

Suggested change
"supported_by": "esphome"
"supported_by": "esphome",
"codeowners": ["@esphome"],
"documentation": "https://www.home-assistant.io/integrations/konnected_esphome/",
"requirements": []

Copilot uses AI. Check for mistakes.
frenck
frenck approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit c8d676e into home-assistant:dev Sep 30, 2025
30 checks passed
@joostlek joostlek deleted the konnected branch September 30, 2025 19:28
frenck pushed a commit that referenced this pull request Oct 1, 2025
@joostlek @frenck
Add Konnected brand (#153280)
f242e29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

cherry-picked cla-signed core integration: konnected_esphome new-integration small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@joostlek @frenck