-
-
Couldn't load subscription status.
- Fork 35.7k
Fix EZVIZ devices merging due to empty MAC addr (#152939) #152981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZVIZ devices merging due to empty MAC addr (#152939) #152981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @RenierM26, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Co-authored-by: Joost Lekkerkerker <[email protected]>
Breaking change
Proposed change
Fixes issue where multiple EZVIZ cameras with empty MAC addresses would be registered as a single device with multiple identifiers instead of separate devices.
When EZVIZ cameras have empty MAC addresses, the device registry was merging multiple cameras into a single device entry because they shared the same empty connection identifier.
This fix only adds MAC address connections when the MAC address is not empty, preventing the unintended device merging.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: