Revert "Deprecate hddtemp" #148482
Merged
Revert "Deprecate hddtemp" #148482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d827cd.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the prior deprecation of the hddtemp integration, restoring its ability to connect via Telnet and removing the deprecation warnings and issue registry entries previously added.
- Remove creation of deprecation
Issueforhddtempinsensor.py - Drop the
DOMAINconstant from__init__.pyand update imports accordingly - Remove the test that asserted a deprecation issue was registered
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/hddtemp/test_sensor.py | Deleted imports and test related to deprecation issue |
| homeassistant/components/hddtemp/sensor.py | Removed create_issue call and associated imports |
| homeassistant/components/hddtemp/init.py | Removed the DOMAIN constant |
Comments suppressed due to low confidence (1)
homeassistant/components/hddtemp/init.py:1
- Removing the
DOMAINconstant may break references in other modules (e.g.,config_flow.py,sensor.py). Consider restoring theDOMAINdefinition in__init__.pyor moving it to a dedicatedconst.py.
"""The hddtemp component."""
8 tasks
zweckj
approved these changes
Jul 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #145850, as the HA docs were wrong. The integration connects via telnet to the hddtemp service. Therefore, you can use it in our containers.
Fixes #146578
Docs PR: home-assistant/home-assistant.io#39941