Support addresses with comma in google_travel_time #145663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51e8b68 to
c458527
Compare
joostlek
reviewed
May 27, 2025
Comment on lines
+11
to
+21
| @pytest.mark.parametrize( | ||
| ("location", "expected_result"), | ||
| [ | ||
| ( | ||
| "12.34,56.78", | ||
| Waypoint( | ||
| location=Location( | ||
| lat_lng=latlng_pb2.LatLng( | ||
| latitude=12.34, | ||
| longitude=56.78, | ||
| ) |
Member
There was a problem hiding this comment.
would this make sense to test at the places where we use this to avoid for example an incorrect schema for the config flow where the same can happen?
Contributor
Author
There was a problem hiding this comment.
As discussed on Discord I think by testing convert_to_waypoint to make sure it does what it is supposed to do, we can trust that its use in the ConfigFlow does also work. Testing the config flow with different set of data would also be a possibility albeit one which needs a bigger set of changes.
c458527 to
6558f14
Compare
joostlek
approved these changes
May 27, 2025
bramkragten
pushed a commit
that referenced
this pull request
May 27, 2025
Support addresses with comma
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes #145660
Having a comma in the address leads to vol.MultipleInvalid. Catching vol.Invalid as the base type fixes the issue.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: