Skip to content

Bump Roborock Map Parser to 0.1.4 #144260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Bump Roborock Map Parser to 0.1.4 #144260

merged 1 commit into from
May 5, 2025

Conversation

@Lash-L
Copy link
Contributor

@Lash-L Lash-L commented May 5, 2025

Breaking change

The big change here is that some of the drawing logic is very optimized now. On some devices with low ram, our update to increase the maps resolution was causing crashes, this fixes it. Should be included in beta if possible!

Library change: PiotrMachowski/Python-package-vacuum-map-parser-roborock@v0.1.2...v0.1.4
Which is based off of: PiotrMachowski/Python-package-vacuum-map-parser-base@v0.1.3...v0.1.5

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Lash-L Lash-L requested a review from allenporter as a code owner May 5, 2025 13:36
@home-assistant
Copy link

home-assistant bot commented May 5, 2025

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@allenporter allenporter added this to the 2025.5.0 milestone May 5, 2025
@allenporter
Copy link
Contributor

allenporter commented May 5, 2025

Does this decrease resolution of the objects like the robot on the map?

@Lash-L
Copy link
Contributor Author

Lash-L commented May 5, 2025 •
edited
Loading

Does this decrease resolution of the objects like the robot on the map?

It should not! My testing shows the maps looking identical - but if you would like to double check that would be helpful!

@allenporter allenporter merged commit aa8dfa7 into home-assistant:dev May 5, 2025
48 checks passed
@allenporter
Copy link
Contributor

allenporter commented May 5, 2025

Does this decrease resolution of the objects like the robot on the map?

It should not! My testing shows the maps looking identical - but if you would like to double check that would be helpful!

Thanks for confirming. I can test in beta also. I think its important to get this memory fix out so appreciate it.

balloob pushed a commit that referenced this pull request May 5, 2025
@Lash-L @balloob
Bump Roborock Map Parser to 0.1.4 (#144260)
6247ec7 
Bump to 0.1.4
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@allenporter allenporter allenporter approved these changes

Assignees

@allenporter allenporter

Labels

by-code-owner cherry-picked cla-signed dependency integration: roborock Quality Scale: silver small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.5.0

Development

Successfully merging this pull request may close these issues.

HA core 2025.4.x crashes with out of memory exception when Roborock integration is active

3 participants

@Lash-L @allenporter @balloob