You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python -m script.licenses check was failing with msg:
Approved license detected for [email protected]: MIT -- None -- []
Please remove the package from the EXCEPTIONS list.
Type of change
Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests
Additional information
This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:
Checklist
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
Now it fails with the reverse error 🙃
Since we don't pin the setuptools version, it gets installed as a dependency from other packages and maybe the version will depend on the order?
I wonder if those packages should have setuptools as an install dependency. If so, should we pin setuptools version?
Now it fails with the reverse error 🙃 Since we don't pin the setuptools version, it gets installed as a dependency from other packages and maybe the version will depend on the order?
I wonder if those packages should have setuptools as an install dependency. If so, should we pin setuptools version?
Consider hardcoding an exception to ignore the setuptools license.
Since it's part of the Python standard packaging ecosystem, it's highly unlikely to pose any issues.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The python -m script.licenses check was failing with msg:
Approved license detected for [email protected]: MIT -- None -- []
Please remove the package from the EXCEPTIONS list.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: