Skip to content

Conversation

@ViViDboarder
Copy link
Contributor

@ViViDboarder ViViDboarder commented May 1, 2025

Breaking change

Proposed change

Bump version to fix change in upstream api paths.

https://github.com/ViViDboarder/py_nextbusnext/releases/tag/v2.1.2

ViViDboarder/py_nextbusnext@v2.0.5...v2.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet changed the title Bump py-nextbusnext version Bump py-nextbusnext to 2.1.2 May 2, 2025
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a change log reference to the PR's description

@home-assistant
Copy link

home-assistant bot commented May 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 2, 2025 07:47
@ViViDboarder
Copy link
Contributor Author

Woops! Added.

@ViViDboarder ViViDboarder marked this pull request as ready for review May 2, 2025 17:24
@home-assistant home-assistant bot requested a review from jbouwh May 2, 2025 17:24
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @ViViDboarder 👍

@jbouwh jbouwh merged commit 97be2c4 into home-assistant:dev May 2, 2025
48 checks passed
@jbouwh jbouwh added this to the 2025.5.0 milestone May 2, 2025
balloob pushed a commit that referenced this pull request May 3, 2025
Bump py-nextbusnext version

Fixes #144059
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not find API key on page // config flow could not be loaded: 500 Internal Server Error Server got itself in trouble

3 participants