-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
Use names instead of statistic IDs in the Opower repair issue #144018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use names instead of statistic IDs in the Opower repair issue #144018
Conversation
| "return_to_grid_migration": { | ||
| "title": "Return to grid statistics for account: {utility_account_id}", | ||
| "description": "We found negative values in your existing consumption statistics, likely because you have solar. We split those in separate return statistics for a better experience in the Energy dashboard.\n\nPlease visit the [Energy configuration page]({energy_settings}) to add the following statistics in the **Return to grid** section:\n\n{target_ids}" | ||
| "description": "We found negative values in your existing consumption statistics, likely because you have solar. We split those in separate return statistics for a better experience in the Energy dashboard.\n\nPlease visit the [Energy configuration page]({energy_settings}) to add the following statistics in the **Return to grid** section:\n\n{target_ids}\n\nOnce you have added them, ignore this issue." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we get the issue to be automatically removed when we don't detect it anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have misunderstood the issue.
Historically the Opower integration has been creating a single statistic for both consumption and return to grid. If you returned to the grid it had negative values. Starting with 2025.5.0 we have a separate return to the grid statistic. And we perform a one time migration. We raise this issue so that users update their energy dashboard config and any other manual dashboard they might have. We could check that the user has updated their energy dashboard by checking config/.storage/energy or making API changes in the energy component but it's not something worth doing. And it won't cover manual dashboards users might have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only open the issue when there has been negative values? That way users without solar won't need to ignore an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. We migrate and open the issue only if we find at least one negative value.
* Use names instead of statistic IDs in the Opower repair issue * target_ids
Breaking change
Proposed change
Use names instead of statistic IDs in the Opower repair issue since the picker now shows names instead of IDs.
Also add a line to skip the issue once done.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: