Skip to content

Conversation

@Lash-L
Copy link
Contributor

@Lash-L Lash-L commented May 13, 2025

Breaking change

Proposed change

Dep changes: Lash-L/python-snoo@v0.6.5...v0.6.6

Changelog: https://github.com/Lash-L/python-snoo/blob/main/CHANGELOG.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

"sticky_white_noise_updated": "Sleepytime sounds updated",
"config_change": "Config changed"
"config_change": "Config changed",
"restart": "Restart"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be in a spearate PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be separate or does it need to be in this PR for things to work properly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a new state which needs translation, judging by the changelog, so I think this is fine

"sticky_white_noise_updated": "Sleepytime sounds updated",
"config_change": "Config changed"
"config_change": "Config changed",
"restart": "Restart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a new state which needs translation, judging by the changelog, so I think this is fine

@zweckj zweckj added this to the 2025.5.2 milestone May 14, 2025
@joostlek joostlek merged commit 577ddd9 into home-assistant:dev May 14, 2025
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants