Skip to content

Conversation

@starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented May 12, 2025

Breaking change

Proposed change

Cleanup wrongly combined Reolink devices, followup to PR #144554
There was an aditional way in which the registry could be messed up:
Multiple IPC cams could be combined with the NVR/Home Hub device due to the wrong identical MAC.
This PR cleans up that mess.

Tested locally on my dev enviroment in which I perpusely messed up my device registry by first reverting to HA 2025.4.0 with a clean install, then adding the NVR, then updating to the code of this PR to have it cleaned up correctly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit 07db244 into home-assistant:dev May 16, 2025
34 checks passed
@frenck frenck mentioned this pull request May 16, 2025
@starkillerOG starkillerOG deleted the reolink_split_device branch May 17, 2025 08:04
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Cameras Adding under one Device Still an Issue. POE Camera's aren't showing up in Home Assistant Reolink Camras Show under 1 device

2 participants