Skip to content

Fix wrong state in Husqvarna Automower #144684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 12, 2025
Merged

Fix wrong state in Husqvarna Automower #144684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1abf70e
Fix wrong state in Husqvarna Automower
Thomas55555 May 11, 2025
82e7bb1
Update test_lawn_mower.py
Thomas55555 May 11, 2025
3f83dc0
Ruff
Thomas55555 May 11, 2025
808bc9c
Fix typo
Thomas55555 May 11, 2025
780ae01
Update test_lawn_mower.py
Thomas55555 May 11, 2025
3231fa8
Update test_lawn_mower.py
Thomas55555 May 11, 2025
324c041
Update test_lawn_mower.py
Thomas55555 May 11, 2025
a97ee4c
Update test_lawn_mower.py
Thomas55555 May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions homeassistant/components/husqvarna_automower/lawn_mower.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ def activity(self) -> LawnMowerActivity:
mower_attributes = self.mower_attributes
if mower_attributes.mower.state in PAUSED_STATES:
return LawnMowerActivity.PAUSED
if mower_attributes.mower.state in MowerStates.IN_OPERATION:
if mower_attributes.mower.activity == MowerActivities.GOING_HOME:
return LawnMowerActivity.RETURNING
return LawnMowerActivity.MOWING
if (mower_attributes.mower.state == "RESTRICTED") or (
mower_attributes.mower.activity in DOCKED_ACTIVITIES
):
return LawnMowerActivity.DOCKED
if mower_attributes.mower.state in MowerStates.IN_OPERATION:
if mower_attributes.mower.activity == MowerActivities.GOING_HOME:
return LawnMowerActivity.RETURNING
return LawnMowerActivity.MOWING
return LawnMowerActivity.ERROR

@property
Expand Down
5 changes: 5 additions & 0 deletions tests/components/husqvarna_automower/test_lawn_mower.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
MowerStates.IN_OPERATION,
LawnMowerActivity.MOWING,
),
(
MowerActivities.PARKED_IN_CS,
MowerStates.IN_OPERATION,
LawnMowerActivity.DOCKED,
),
],
)
async def test_lawn_mower_states(
Expand Down