Skip to content

Conversation

@DukeChocula
Copy link
Contributor

@DukeChocula DukeChocula commented May 8, 2025

Added LAP-V102S-AUSR as Vital 100S variant

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Added LAP-V102S-AUSR to Vital 100S
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DukeChocula

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added cla-needed integration: vesync small-pr PRs with less than 30 lines. labels May 8, 2025
@home-assistant home-assistant bot marked this pull request as draft May 8, 2025 03:02
@home-assistant
Copy link

home-assistant bot commented May 8, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented May 8, 2025

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @cdnninja, @iprak, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@DukeChocula DukeChocula marked this pull request as ready for review May 8, 2025 03:09
@home-assistant home-assistant bot dismissed their stale review May 8, 2025 03:09

Stale

@DukeChocula DukeChocula marked this pull request as draft May 8, 2025 03:40
@DukeChocula DukeChocula marked this pull request as ready for review May 8, 2025 03:45
@thecode thecode changed the title Update const.py Add LAP-V102S-AUSR to VeSync May 8, 2025
@thecode thecode added the bugfix label May 8, 2025
@joostlek joostlek added this to the 2025.5.1 milestone May 9, 2025
@joostlek joostlek merged commit 90a7ecd into home-assistant:dev May 9, 2025
34 checks passed
frenck pushed a commit that referenced this pull request May 9, 2025
Update const.py

Added LAP-V102S-AUSR to Vital 100S
@frenck frenck mentioned this pull request May 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entities missing for LAP-V102S-AUSR version of Vital 100S

4 participants