Skip to content

Conversation

@vingerha
Copy link
Contributor

@vingerha vingerha commented Apr 17, 2025

Breaking change

Proposed change

Adding new states, provided by MF API since mid April

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (meteo_france) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of meteo_france can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign meteo_france Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Quentame
Copy link
Member

Thanks 🙏

@Quentame Quentame merged commit 54def1a into home-assistant:dev Apr 17, 2025
34 checks passed
@WarC0zes
Copy link

WarC0zes commented Apr 17, 2025

There are probably other new conditions.
like Averses de neige faible, Pluie modérée, Pluie et neige, Variable.

image

@vingerha
Copy link
Contributor Author

Could be but as long as there is no definitive list and I have not seen a proper source (searched for a while) and I cannot guess this until it happens

@vingerha
Copy link
Contributor Author

There are probably other new conditions. like Averses de neige faible, Pluie modérée, Pluie et neige.

Where did you find these states? Please note that the MF card is not defining MF states, it is just retranslating

@WarC0zes
Copy link

WarC0zes commented Apr 17, 2025

Il existe probablement d'autres nouvelles conditions, comme Averses de neige faible, Pluie modérée, Pluie et neige.

Où avez-vous trouvé ces états ? Veuillez noter que la carte MF ne définit pas les états MF, elle les retraduit simplement.

On MF site.
image
image
image
image

@vingerha
Copy link
Contributor Author

On MF site.

Yeah but this is not a definitive list and you can only detect it when it happens

@Quentame : I am happy to add other PR based on above but it will not be a 100% coverage, let me know what you think

@vingerha vingerha deleted the meteofrance branch April 17, 2025 08:20
@vingerha
Copy link
Contributor Author

vingerha commented Apr 18, 2025

@Quentame I spent an hour looking for things but still not found a list of existing forecast states. The other thing is that I have no clue if MF replaced states, e.g. "Ciel clair" is new for a clear_night (I will change in the next PR) but the current mappings contain "Nuit Claire" and "Nuit claire" and not a clue if these are maintained rom MF API. For "Variable" there is no good match other and closest seems partlycloudy. I highly doubt if HA would become more detailed on forecast states...but maybe you know more?
All in all, the next PR will contain above and I guess we just have to take it as it comes...unless someone finds the definitive list and then I am happy to rework all.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2025
@Quentame Quentame added this to the 2025.4.4 milestone Apr 20, 2025
@Quentame Quentame changed the title Meteofrance: adding new states provided by MF API since mid April Météo-France: adding new states provided by MF API since mid April Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meteo France is throwing incorrect (French) statuses

4 participants