Skip to content

Increase uptime deviation for Shelly #142996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2025
Merged

Increase uptime deviation for Shelly #142996

merged 5 commits into from
Apr 16, 2025

Conversation

@chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Apr 15, 2025 •
edited
Loading

Proposed change

Using newer firmwares ( 1.6.0beta, 1.5.1) showed that 5s is not enough.
Not sure when it started but at least Shelly Plug S Gen3 (S3PL-00112EU) with firmware 20240820-134301/1.2.3-plugsg3prod0-gec79607 is affected.

Below some screenshot for devices with 1.5.1 or 1.6.0beta:

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 added this to the 2025.4.3 milestone Apr 15, 2025
@home-assistant
Copy link

home-assistant bot commented Apr 15, 2025

Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@thecode
Copy link
Member

thecode commented Apr 15, 2025

Adding a comment here as we discussed, please edit the PR description and replace the "Using new firmwares" with the firmware version that breaks and needs this fix.

@chemelli74
Copy link
Contributor Author

chemelli74 commented Apr 15, 2025

Adding a comment here as we discussed, please edit the PR description and replace the "Using new firmwares" with the firmware version that breaks and needs this fix.

I didn't added at first, because I have different firmwares with the issue.
And I don't have a device with old one to compare to :(

Added some logging, and found out that devices not affected are still border line:

2025-04-15 17:23:59.704 WARNING (MainThread) [homeassistant.components.shelly] Uptime: 417628 - Last uptime: 2025-04-10 19:23:35.221391+00:00 - Delta uptime: 2025-04-10 19:23:31.704153+00:00

@chemelli74
Copy link
Contributor Author

chemelli74 commented Apr 15, 2025

Never got more than 6s deviation. Maybe we can use that as a value:

2025-04-15 20:00:28.759 DEBUG (MainThread) [homeassistant.components.shelly] Time deviation 5.359387 > 5: uptime=24827, last_uptime=2025-04-15 11:06:47.119006+00:00, delta_uptime=2025-04-15 11:06:41.759619+00:00
2025-04-15 20:00:28.860 DEBUG (MainThread) [homeassistant.components.shelly] Time deviation 5.340547 > 5: uptime=24873, last_uptime=2025-04-15 11:06:01.201003+00:00, delta_uptime=2025-04-15 11:05:55.860456+00:00
2025-04-15 20:00:28.972 DEBUG (MainThread) [homeassistant.components.shelly] Time deviation 5.217981 > 5: uptime=430490, last_uptime=2025-04-10 18:25:44.190467+00:00, delta_uptime=2025-04-10 18:25:38.972486+00:00
2025-04-15 20:00:29.002 DEBUG (MainThread) [homeassistant.components.shelly] Time deviation 5.262358 > 5: uptime=384157, last_uptime=2025-04-11 07:17:57.264560+00:00, delta_uptime=2025-04-11 07:17:52.002202+00:00

@chemelli74
Copy link
Contributor Author

chemelli74 commented Apr 16, 2025

Thx @bdraco and @bieniu !

@chemelli74 chemelli74 merged commit 44d6f0b into home-assistant:dev Apr 16, 2025
34 checks passed
@chemelli74 chemelli74 deleted the chemelli74-shelly-uptime branch April 16, 2025 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bieniu bieniu bieniu approved these changes

@bdraco bdraco bdraco approved these changes

@balloob balloob Awaiting requested review from balloob

@thecode thecode Awaiting requested review from thecode thecode is a code owner

Assignees

@bieniu bieniu

@bdraco bdraco

@balloob balloob

@thecode thecode

Labels

bugfix by-code-owner cherry-picked cla-signed integration: shelly Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@chemelli74 @thecode @bieniu @bdraco @frenck @balloob