-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
Netatmo: do not fail on schedule updates #142933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netatmo: do not fail on schedule updates #142933
Conversation
|
Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this?
I don't see how. The change has no effect on the internal state. |
But we can try doing a request with an invalid payload and then see that it just handles it correctly? Because I would assume something now doesn't work like expected? |
Before my change the raised KeyError was handled in the event processing pipeline and never bubbled up. I can write a test to ensure that the stored data remains unchanged. But I can't test for the KeyError. Or at least I don't know how. |
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! Now we at least ensure that we don't regress :D
Breaking change
Proposed change
This PR ensures, that the integration gracefully handles a schedule update communicated through the webhook.
example webhook payload:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: