Skip to content

Conversation

@tsvi
Copy link
Contributor

@tsvi tsvi commented Apr 14, 2025

Proposed change

This should go in 2025.4 point release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tsvi 👍

../Frenck

@frenck frenck added this to the 2025.4.3 milestone Apr 14, 2025
@frenck frenck merged commit 1480b77 into home-assistant:dev Apr 14, 2025
34 checks passed
@tsvi tsvi deleted the jcal-bugfix branch April 14, 2025 10:21
@tsvi
Copy link
Contributor Author

tsvi commented Apr 14, 2025

Wow that was fast 😃

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jewish Calendar prevented me from upgrading to 2025.4.1, and now is crashing

3 participants