Fix message corruption in picotts component #141182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the newer subprocess.run method and checking the pico2wave return code.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
Author
|
I was unable to run the full test suite due a lot of "No module named" errors during tests collection, using the DevContainer environment, regardless installation of all dev and test requirements. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
homeassistant/components/picotts/tts.py:63
- [nitpick] Consider capturing stderr (e.g., by setting capture_output=True in subprocess.run) and logging it along with the return code to provide clearer diagnostics when pico2wave fails.
if result.returncode != 0:
edenhaus
approved these changes
May 5, 2025
balloob
pushed a commit
that referenced
this pull request
May 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This fixes #93456, by sending the message to pico2wave subprocess using the stdin instead of command line arguments, as command line arguments seem to cause issues without a clear root cause.
Usage of stdin should be security equivalent, if not more secure, to usage of command line argument in shell-less subprocesses.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: