Skip to content

Fix hdmi-cec initialization #66172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix hdmi-cec initialization #66172

merged 1 commit into from
Feb 9, 2022

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented Feb 9, 2022 •
edited
Loading

Proposed change

Fixes #66106, introduced in #63791

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor Author

epenet commented Feb 9, 2022

cc @Hamper / @thecode / @frenck

@epenet
Copy link
Contributor Author

epenet commented Feb 9, 2022

@Hamper could you please test this and confirm?

@epenet epenet added this to the 2022.2.6 milestone Feb 9, 2022
@Hamper
Copy link

Hamper commented Feb 9, 2022

I updated to core-2022.2.5 and now no KeyError with not modified integration, but device still not created.
Current logs:

2022-02-09 17:27:46 DEBUG (SyncWorker_4) [homeassistant.components.hdmi_cec] Parsing config OrderedDict([('TV', '0.0.0.0')])
2022-02-09 17:27:46 DEBUG (SyncWorker_4) [homeassistant.components.hdmi_cec] Parsed devices: {'TV': <pycec.network.PhysicalAddress object at 0xad272bb0>}
2022-02-09 17:28:14 WARNING (SyncWorker_0) [pycec] Not initialized. Waiting for init.

2022-02-09 17:30:14 DEBUG (SyncWorker_6) [homeassistant.components.hdmi_cec] Reached _adapter_watchdog
2022-02-09 17:32:14 DEBUG (SyncWorker_5) [homeassistant.components.hdmi_cec] Reached _adapter_watchdog

I'll try to debug later

@epenet
Copy link
Contributor Author

epenet commented Feb 9, 2022

This hotfix is not part of 2022.2.5. It hasn't been merged yet!

@balloob balloob merged commit 567f07c into home-assistant:dev Feb 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
@epenet epenet deleted the fix-hdmi-cic branch February 11, 2022 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

bugfix cherry-picked cla-signed integration: hdmi_cec small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2022.2.6

Development

Successfully merging this pull request may close these issues.

hdmi_cec network KeyError

4 participants

@epenet @Hamper @balloob @homeassistant