Skip to content

Conversation

bjpetit
Copy link
Contributor

@bjpetit bjpetit commented Jun 15, 2021

Proposed change

If an ecobee thermostat goes offline, set the humidifier, occupancy sensor and temperature sensor state
appropriately, rather than returning stale data.

  • Add the available property to the humidifier, sensor and binary_sensor properties
  • Return true if thermostat is connected, false otherwise

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

to humidifier, and remote sensors.
implement the available property
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Add handling of disconnected ecobee thermostat to humidifier and remote sensors Handle disconnected ecobee thermostat in humidifier and remote sensors Jun 18, 2021
@MartinHjelmare MartinHjelmare merged commit c149ecf into home-assistant:dev Jun 18, 2021
@bjpetit bjpetit deleted the thermostat_offline branch June 18, 2021 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Climate offline, temperature sensor still reports value

3 participants