Skip to content

Conversation

farmio
Copy link
Contributor

@farmio farmio commented Jan 7, 2021

Proposed change

When we do not know the position of a cover (eg. after restart of HA) we now return None for is_closed() so the state resolves to "unknown".
self._device.current_position() is None on init. When the cover is moved once the state gets calculated in xknx internally - so it is always available even if no position_state_address is configured.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title KNX Cover: fix state return open when unknown Fix KNX cover state return open when unknown Jan 8, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Should we tag this for a patch release?

@farmio
Copy link
Contributor Author

farmio commented Jan 8, 2021

Yes, that would work without problems.

@MartinHjelmare MartinHjelmare added this to the 2021.1.1 milestone Jan 8, 2021
@MartinHjelmare MartinHjelmare merged commit 30189fb into home-assistant:dev Jan 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2021
@farmio farmio deleted the fix-cover-not-initialized branch June 15, 2021 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants