Defer triggering derivations until Finalize
#1691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1691 +/- ##
=======================================
Coverage 82.72% 82.72%
=======================================
Files 559 559
Lines 77235 77217 -18
=======================================
- Hits 63889 63877 -12
+ Misses 13346 13340 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zickgraf
added a commit
to zickgraf/FinSetsForCAP
that referenced
this pull request
Sep 25, 2024
zickgraf
added a commit
to zickgraf/FinSetsForCAP
that referenced
this pull request
Sep 25, 2024
zickgraf
added a commit
to homalg-project/FinSetsForCAP
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has already been proposed a long time ago in #144. There is only one drawback: Applying
CanComputeto unfinalized categories now only takes primitive operations into account. This might require some minor changes as can be seen inAdditiveClosure.gi.