-
Notifications
You must be signed in to change notification settings - Fork 18
chore(api): log /api/v1/healthz requests at debug level instead of info to reduce noise #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…fo to reduce noise
|
@obazoud is attempting to deploy a commit to the Hookdeck Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reduces logging noise by changing the log level for health check requests from info to debug. This is a common practice to avoid cluttering logs with frequent health check calls that don't provide operational value.
- Changes logging level for
/api/v1/healthzrequests from info to debug
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if c.Request.URL.Path == "/api/v1/healthz" { | ||
| logger.Debug("healthz request completed", fields...) | ||
| } else { | ||
| logger.Info("request completed", fields...) | ||
| } |
Copilot
AI
Sep 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is inconsistent with the rest of the codebase. The if-else block should use tabs to match the surrounding code formatting.
| if c.Request.URL.Path == "/api/v1/healthz" { | |
| logger.Debug("healthz request completed", fields...) | |
| } else { | |
| logger.Info("request completed", fields...) | |
| } | |
| if c.Request.URL.Path == "/api/v1/healthz" { | |
| logger.Debug("healthz request completed", fields...) | |
| } else { | |
| logger.Info("request completed", fields...) | |
| } |
Copilot uses AI. Check for mistakes.
| } | ||
| } else { | ||
| logger.Info("request completed", fields...) | ||
| if c.Request.URL.Path == "/api/v1/healthz" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, would it be better to check "string ending with /healthz and starting with /api" so it works for new versions in the future.
Not a big deal tho, just let me know, we can merge as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for your contribution!
No description provided.