Skip to content

Conversation

obazoud
Copy link
Contributor

@obazoud obazoud commented Sep 6, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 6, 2025 12:05
@vercel
Copy link

vercel bot commented Sep 6, 2025

@obazoud is attempting to deploy a commit to the Hookdeck Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces logging noise by changing the log level for health check requests from info to debug. This is a common practice to avoid cluttering logs with frequent health check calls that don't provide operational value.

  • Changes logging level for /api/v1/healthz requests from info to debug

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 63 to 67
if c.Request.URL.Path == "/api/v1/healthz" {
logger.Debug("healthz request completed", fields...)
} else {
logger.Info("request completed", fields...)
}
Copy link

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent with the rest of the codebase. The if-else block should use tabs to match the surrounding code formatting.

Suggested change
if c.Request.URL.Path == "/api/v1/healthz" {
logger.Debug("healthz request completed", fields...)
} else {
logger.Info("request completed", fields...)
}
if c.Request.URL.Path == "/api/v1/healthz" {
logger.Debug("healthz request completed", fields...)
} else {
logger.Info("request completed", fields...)
}

Copilot uses AI. Check for mistakes.

}
} else {
logger.Info("request completed", fields...)
if c.Request.URL.Path == "/api/v1/healthz" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, would it be better to check "string ending with /healthz and starting with /api" so it works for new versions in the future.

Not a big deal tho, just let me know, we can merge as-is.

Copy link
Collaborator

@alexluong alexluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for your contribution!

@alexluong alexluong merged commit 61dc19a into hookdeck:main Sep 8, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants