Skip to content

Conversation

@leggetter
Copy link
Collaborator

Introduce scripts and configurations to deploy Outpost services on Azure Container Apps, including environment setup and validation steps.

Copilot AI review requested due to automatic review settings July 30, 2025 21:07
@vercel
Copy link

vercel bot commented Jul 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outpost-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 11:08pm
outpost-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 11:08pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces deployment scripts and configuration for running Outpost services on Azure Container Apps with Azure Service Bus as the message queue. The implementation provides both local Docker deployment and Azure Container Apps deployment options with comprehensive environment setup and validation capabilities.

Key changes:

  • Azure dependencies provisioning with PostgreSQL, Redis, and Service Bus
  • Local Docker Compose deployment configuration
  • Azure Container Apps deployment automation
  • Comprehensive diagnostics and validation tooling

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
examples/azure/dependencies.sh Provisions Azure infrastructure including PostgreSQL, Redis, Service Bus and service principal
examples/azure/local-deploy.sh Deploys Outpost services locally using Docker Compose with Azure backends
examples/azure/azure-deploy.sh Deploys Outpost services to Azure Container Apps
examples/azure/diagnostics.sh Comprehensive validation and testing script for both local and Azure deployments
examples/azure/docker-compose.yml Docker Compose configuration for local deployment
examples/azure/README.md Complete deployment documentation and instructions
examples/azure/.gitignore Excludes environment files from version control

--location "$LOCATION" \
--sku Basic \
--vm-size c0
--enable-non-ssl-port # Comment out or remove if you only want SSL
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling non-SSL port for Redis poses a security risk. Consider using SSL-only connections or add proper documentation about the security implications.

Suggested change
--enable-non-ssl-port # Comment out or remove if you only want SSL
# SSL-only connections enforced for Redis

Copilot uses AI. Check for mistakes.
--location "$LOCATION" \
--sku Basic \
--vm-size c0
--enable-non-ssl-port # Comment out or remove if you only want SSL
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line continuation backslash before the comment. This will cause the command to fail.

Suggested change
--enable-non-ssl-port # Comment out or remove if you only want SSL
--enable-non-ssl-port \ # Comment out or remove if you only want SSL

Copilot uses AI. Check for mistakes.

# Prepare environment variables for deployment
echo "Preparing environment variables for deployment..."
ENV_VARS_STRING=$(grep -v '^#' .env.runtime | sed 's/^export //g' | sed 's/"//g' | tr '\n' ' ')
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sed command removing quotes may break environment variables that contain spaces or special characters. Consider preserving quotes or using a more robust parsing method.

Suggested change
ENV_VARS_STRING=$(grep -v '^#' .env.runtime | sed 's/^export //g' | sed 's/"//g' | tr '\n' ' ')
ENV_VARS_STRING=$(awk -F= '/^[^#]/ {print $1 "=" $2}' .env.runtime | tr '\n' ' ')

Copilot uses AI. Check for mistakes.
@leggetter leggetter merged commit 3ba0d61 into main Aug 1, 2025
4 of 6 checks passed
@leggetter leggetter deleted the feat/azure-setup-example branch August 1, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants