Feat/logger #80
Merged
Feat/logger #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add comprehensive winston logger options - remove status code based skip key in morgan - fix typo - fix logger file structure
wajeshubham
requested changes
Feb 7, 2024
package-lock.json
Outdated
Collaborator
There was a problem hiding this comment.
Please use yarn as a package manager and not npm. Delete the package-lock.json and make sure yarn.lock only has newly installed dependency changes
Collaborator
There was a problem hiding this comment.
Remove package-lock.json and reinstall packages using yarn
Contributor
Author
|
Successfully Implemented the mentioned changes apologize for previous mistakes as this was my first time contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Logger Folder
Created a logger for Applications Errors with Winston and for logging http call using Morgon
Since the output format and the method was not mentioned used custom format and displayed the output to the Console
Happy to make any changes if further infromation is provided by the maintainers
Demo image which shows both application error and http log
