Skip to content

Conversation

@joshuasing
Copy link
Contributor

Add a configuration preset (reusable) for Renovate bot and use it in this repository.

This configuration will:

  • Create dependency update pull requests weekly, on Mondays.
  • Pin Docker images to SHA256 digests.
  • Pin GitHub Actions to SHA1 commit hashes.
  • Pin all NPM dependencies except peer dependencies (this can be overridden per repository if necessary)
  • Enable vulnerability alerts.
  • Create pull request titles/commit messages in the format: all: update X to v1.2.3 (e.g. all: update image golang to 1.24.4-alpine3.21, all: update actions/checkout action to v4.5.0)
  • Add label to pull requests: type: dependencies

This configuration is a base, and should be improved later as needed - it can also be reused in other repositories (with optional overrides) in the future if we want.

@joshuasing joshuasing requested a review from a team as a code owner April 24, 2025 16:15
Copy link

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't used it before so I can't say if there are other options we should set but this looks like a very reasonable start.

OK

Copy link
Contributor

@gabmontes gabmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I don't think this is the most desirable outcome:

  • Pin Docker images to SHA256 digests.
  • Pin GitHub Actions to SHA1 commit hashes.

And if we are automatically updating the hashes of the actions and images, we are losing all the benefits of pinning those. So it is much simpler to use tags for trusted targets. Otherwise we should do a full audit of the target before pinning it to a hash and re-do the audit for every hash change.

@jcvernaleo
Copy link

We can't audit every dep, but at least if we pin by hash, we know we are getting the same thing each time.

Obviously, once github fixes the immutable action stuff at which point it is a totally different discussion.

The question isn't 'is pinning to hash' perfect, but is it better?

@gndelia
Copy link
Contributor

gndelia commented Apr 30, 2025

if I understood correctly, I think there are several rules that can be configured for RenovateBot (similar to Dependabot). Perhaps we could pin actions with hashes with one rule, and use a different rule for docker and github actions. This would be in line with what discussed online, about allowing known actions to be used with tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants