Skip to content

fix: legacy docker support broken for login #30941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

fix: legacy docker support broken for login #30941

merged 1 commit into from
May 30, 2025
+2 −2

Conversation

TerryHowe
Copy link
Contributor

What this PR does / why we need it:
Map to the legacy server

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2025
@scottrigby
Copy link
Member

backport of fix at #30937

@scottrigby scottrigby added the v3.x Issues and Pull Requests related to the major version v3 label May 30, 2025
@scottrigby scottrigby added this to the 3.18.2 milestone May 30, 2025
mattfarina
mattfarina approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fixes the same as the change for main.

@scottrigby scottrigby mentioned this pull request May 30, 2025
Closed
@mattfarina mattfarina merged commit a963208 into helm:dev-v3 May 30, 2025
5 checks passed
@scottrigby scottrigby added the picked Indicates that a PR has been cherry-picked into the next release candidate. label May 31, 2025
@TerryHowe TerryHowe deleted the legacy-docker branch September 7, 2025 12:35
@github-actions github-actions bot mentioned this pull request Sep 14, 2025
Open
@7kazh7
Copy link

7kazh7 commented Sep 17, 2025

@scottrigby
@scottrigby
Member
Member
scottrigby commented on May 30
backport of fix at #30937

@scottrigby scottrigby added the v3.x label on May 30
@scottrigby scottrigby added this to the 3.18.2 milestone on May 30
mattfarina
mattfarina approved these changes on May 30
Collaborator
mattfarina left a comment
Verified fixes the same as the change for main.

@scottrigby scottrigby mentioned this pull request on May 30
"helm pull" fails with "response status code 401", maybe OCI related #30942
Closed
@mattfarina mattfarina merged commit a963208 into helm:dev-v3 on May 30
5 checks passed
@scottrigby scottrigby added the picked label on May 31
@TerryHowe TerryHowe deleted the legacy-docker branch last week
@github-actions github-actions bot mentioned this pull request 4 days ago
Bump helm from v3.15.4 to v3.19.0 kokyhm/kubespray#292
Open
Merge info
Pull request successfully merged and closed
You're all set — the branch has been merged.

@7kazh7

Add a comment
Comment

Add your comment here...

Remember, contributions to this repository should follow its contributing guidelines, security policy, and code of conduct.
ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views.
Reviewers
@mattfarina
mattfarina
Assignees
No one assigned
Labels
picked
size/XS
v3.x
Projects
None yet
Milestone
3.18.2
Development
Successfully merging this pull request may close these issues.

None yet

Notifications
Customize
You’re not receiving no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

Assignees

No one assigned

Labels

picked Indicates that a PR has been cherry-picked into the next release candidate. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Milestone

3.18.2

Development

Successfully merging this pull request may close these issues.

4 participants

@TerryHowe @scottrigby @7kazh7 @mattfarina