Skip to content

Fix race condition in TestInstallRelease_Wait_Interrupted test #13085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix race condition in TestInstallRelease_Wait_Interrupted test #13085

merged 1 commit into from
Jul 8, 2024

Conversation

alex-kattathra-johnson
Copy link
Contributor

Fixes #12961

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2024
mattfarina
mattfarina approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense due to the race condition of getting a response to be checked and timing out.

@mattfarina mattfarina added this to the 3.15.2 milestone Jun 10, 2024
@mattfarina mattfarina added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Jun 10, 2024
@alex-kattathra-johnson
Copy link
Contributor Author

alex-kattathra-johnson commented Jun 11, 2024 •
edited
Loading

Right, there's a race condition between SetStatus in the background context and the validation of the Status.

@mattfarina mattfarina modified the milestones: 3.15.2, 3.15.3 Jun 12, 2024
@joejulian joejulian merged commit 4278ada into helm:main Jul 8, 2024
@alex-kattathra-johnson alex-kattathra-johnson deleted the issue-12961 branch July 8, 2024 23:49
joejulian added a commit that referenced this pull request Jul 9, 2024
@joejulian
Merge pull request #13085 from alex-kattathra-johnson/issue-12961
eb4cf60 
Fix race condition in TestInstallRelease_Wait_Interrupted test

(cherry picked from commit 4278ada)
@mattfarina mattfarina added picked Indicates that a PR has been cherry-picked into the next release candidate. and removed Has One Approval This PR has one approval. It still needs a second approval to be merged. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

@joejulian joejulian joejulian approved these changes

Assignees

No one assigned

Labels

picked Indicates that a PR has been cherry-picked into the next release candidate. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

3.15.3

Development

Successfully merging this pull request may close these issues.

UnitTest Failed in case TestInstallRelease_Wait_Interrupted

3 participants

@alex-kattathra-johnson @mattfarina @joejulian