Skip to content

Conversation

@jasonpilz
Copy link
Member

@jasonpilz jasonpilz commented Oct 9, 2025

🛠️ Description

  • Introduces multiple geography support, including us (existing) and eu (new) geographies.
  • Upgrades HCP SDK version, which includes underlying support the config and auth.
  • Updates hcp auth login to have a new --geography flag.
  • Updates hcp profile profiles create to have a new --geography flag.
  • Updates Profiles to store geography information and uses that to detect cached authentication divergence.

🔗 Additional Link

🏗️ Local Testing

👍 Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

PCI review checklist

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've worked with GRC to document the impact of any changes to security controls.

    Examples of changes to controls include access controls, encryption, logging, etc.

  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.

    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@jasonpilz jasonpilz self-assigned this Oct 9, 2025
…e the correct config options to establish HCP clients via hcp sdk
…ting auth check and results in unclear messaging to user
- Allow new geography flag
- Add syncing functionality with profile and cred cache
@jasonpilz jasonpilz requested a review from meirish October 30, 2025 17:08
@jasonpilz jasonpilz marked this pull request as ready for review November 4, 2025 18:25
@jasonpilz jasonpilz requested review from a team as code owners November 4, 2025 18:25
Copy link
Contributor

@huikang huikang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested the branch and it works as expected. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants