-
Notifications
You must be signed in to change notification settings - Fork 241
build(deps): bump the github-actions group with 2 updates #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump the github-actions group with 2 updates #1518
Conversation
Bumps the github-actions group with 2 updates: [miniscruff/changie-action](https://github.com/miniscruff/changie-action) and [actions/setup-go](https://github.com/actions/setup-go). Updates `miniscruff/changie-action` from 2.0.0 to 2.1.0 - [Release notes](https://github.com/miniscruff/changie-action/releases) - [Changelog](https://github.com/miniscruff/changie-action/blob/main/CHANGELOG.md) - [Commits](miniscruff/changie-action@6dcc253...5036dff) Updates `actions/setup-go` from 5.5.0 to 6.0.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@d35c59a...4469467) --- updated-dependencies: - dependency-name: miniscruff/changie-action dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: actions/setup-go dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
dc49c8a
to
9b31ecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we got the tools
module bumped already here, so this one just needs a changelog, an adjustment for the patch version, and a way forward for that unit test 🤔
Since you mentioned that the unit test was failing on main it's unlikely to be anything changed in this PR, just probably a flakey test that needs to be adjusted. Something might have recently changed on developer.hashicorp.com
to prevent these types of requests, so maybe a new endpoint could be used (perhaps something more stable? 😆 )
I saw an issue in the TF repo recently that was around vercel challenging HTTP requests, so there may be some new protection on the site, perfect timing 😆: hashicorp/terraform#37566
go.mod
Outdated
go 1.23.0 | ||
|
||
toolchain go1.23.7 | ||
go 1.24.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion as here -> hashicorp/terraform-plugin-framework#1217 (comment)
9b31ecb
to
97d2c43
Compare
97d2c43
to
2cad21f
Compare
2cad21f
to
d39288c
Compare
multiline | ||
request body` | ||
req, _ := http.NewRequest("GET", "https://developer.hashicorp.com/terraform", bytes.NewBufferString(reqBody)) | ||
req, _ := http.NewRequest("GET", "https://github.com/", bytes.NewBufferString(reqBody)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test exhibits strange behaviours, the cause of which I haven't been able to find.
What I've observed:
- Running test locally will fail as it expects the second entry to have a http version of
HTTP/1.1
- Running test locally in debug mode passes
- Running test in GHA passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe a good long term replacement is just setting up a test HTTP server (httptest
package) and calling it. So it stays e2e, but at least is fully controllable. Out of scope for this PR 😆
multiline | ||
request body` | ||
req, _ := http.NewRequest("GET", "https://developer.hashicorp.com/terraform", bytes.NewBufferString(reqBody)) | ||
req, _ := http.NewRequest("GET", "https://github.com/", bytes.NewBufferString(reqBody)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe a good long term replacement is just setting up a test HTTP server (httptest
package) and calling it. So it stays e2e, but at least is fully controllable. Out of scope for this PR 😆
Bumps the github-actions group with 2 updates: miniscruff/changie-action and actions/setup-go.
Updates
miniscruff/changie-action
from 2.0.0 to 2.1.0Release notes
Sourced from miniscruff/changie-action's releases.
Changelog
Sourced from miniscruff/changie-action's changelog.
Commits
5036dff
support install only and custom work dir (#302)a6093f5
Bump the node-deps group with 3 updates (#299)a78ca2b
Bump the node-deps group with 3 updates (#298)07f1ae3
Bump actions/checkout from 4 to 5 in the action-deps group (#297)2c1effc
Bump the node-deps group with 3 updates (#296)fc96aa3
Bump the node-deps group with 8 updates (#295)983f75a
Bump the node-deps group across 1 directory with 8 updates (#293)59c7589
Bump the node-deps group with 6 updates (#290)e9b8ae5
Bump the node-deps group with 8 updates (#289)25e3d52
Bump the node-deps group with 6 updates (#288)Updates
actions/setup-go
from 5.5.0 to 6.0.0Release notes
Sourced from actions/setup-go's releases.
Commits
4469467
Bump actions/checkout from 4 to 5 (#631)e093d1e
Node 24 upgrade (#624)1d76b95
Improve toolchain handling (#460)e75c3e8
Bumpform-data
to bring in fix for critical vulnerability (#618)8e57b58
Bump eslint-plugin-jest from 28.11.0 to 29.0.1 (#603)7c0b336
Bump typescript from 5.4.2 to 5.8.3 (#538)6f26dcc
Bump undici from 5.28.5 to 5.29.0 (#594)8d4083a
Bump@typescript-eslint/parser
from 5.62.0 to 8.32.0 (#590)fa96338
Bump@actions/tool-cache
from 2.0.1 to 2.0.2 (#591)4de67c0
Bump@types/jest
from 29.5.12 to 29.5.14 (#589)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions