Have DB creation script account for username #375
Conversation
onelapahead
left a comment
There was a problem hiding this comment.
lgtm otherwise! Thanks for finding this edge case and submitting a fix.
| DB_NAME=`echo ${DB_PARAMS} | sed 's!?.*!!'` | ||
| echo "Database name: '${DB_NAME}'" | ||
| USER_NAME=`echo ${PSQL_URL} | sed 's!^.*//!!' | sed 's!:.*$!!'` | ||
| echo "Username: '${USER_NAME}'" |
There was a problem hiding this comment.
Does this still work if the DB doesn't require auth? Know thats a bit unlikely / harder to test.
There was a problem hiding this comment.
Yeah that's a good point. Now, we need connection strings in at least this format:
"postgresql://[username]:[password]/[database]"
Looking at their doc (https://www.postgresql.org/docs/current/libpq-connect.html), supporting all formats of connection strings would be pretty difficult. Wondering what we need to support here? @peterbroadhurst and @hfuss any insights from what you've previously deployed? It may also be easier to provide the PSQL connection info as separate chart values instead of winding up with all this sed echo fun | sed 's/fun/suffering/'.
There was a problem hiding this comment.
I think assuming the PSQL string will have basic auth creds is fine for now. Most users are going to have a setup like that when using the chart.
|
@drewmarshburn please rebase your PR off the latest upstream/main to get the changes from #359 and to retrigger the Go build that broke yesterday. This should be good to merge after that. |
ed6e77b to
ed532f6
Compare
Signed-off-by: Drew Marshburn <[email protected]>
ed532f6 to
54297f1
Compare
Signed-off-by: Drew Marshburn <[email protected]>
This script previously made incorrect assumptions about the name of the database user and the name of the database. Providing connection strings with no db name initiates a connection using the username as the database name. Instead, the connection should always be made to the default
postgresdatabase.