Reduce overhead of gocritic #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 234 234
Lines 12793 12793
=========================================
Hits 12793 12793 Continue to review full report at Codecov.
|
Contributor
|
Guess it's just a cost-benefit discussion. This does remove some checks that have been flagged before (and therefore prompted us to make micro-optimizations). The overall return on these types of optimizations may not be large though. |
Contributor
Author
+1 to this this assessment. Guess I've placed my vote by raising this, and am interested in the other maintainers thoughts. |
nguyer
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration - this seems to reduce the overhead significantly.