Skip to content

Use WriteByte instead of WriteRune when possible #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2021
Merged

Use WriteByte instead of WriteRune when possible #314

merged 1 commit into from
Nov 8, 2021

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Nov 4, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #314 (bb4c753) into main (0271525) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #314   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          229       230    +1     
  Lines        12562     12574   +12     
=========================================
+ Hits         12562     12574   +12
Impacted Files Coverage Δ
internal/apiserver/route_get_token_accounts.go 100.00% <ø> (ø)
internal/apiserver/route_get_token_pool_by_name.go 100.00% <ø> (ø)
...nternal/apiserver/route_get_token_pools_by_type.go 100.00% <ø> (ø)
...nal/apiserver/route_get_token_transfers_by_pool.go 100.00% <ø> (ø)
...nternal/apiserver/route_post_token_burn_by_type.go 100.00% <ø> (ø)
...nternal/apiserver/route_post_token_mint_by_type.go 100.00% <ø> (ø)
...nternal/apiserver/route_post_token_pool_by_type.go 100.00% <ø> (ø)
...nal/apiserver/route_post_token_transfer_by_type.go 100.00% <ø> (ø)
...rnal/apiserver/route_get_token_accounts_by_pool.go 100.00% <100.00%> (ø)
internal/apiserver/route_get_token_balances.go 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d5d97...bb4c753. Read the comment docs.

@nguyer nguyer merged commit 90f0a6d into hyperledger:main Nov 8, 2021
@nguyer nguyer deleted the rune branch November 8, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbroadhurst peterbroadhurst Awaiting requested review from peterbroadhurst

1 more reviewer

@nguyer nguyer nguyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awrichar @codecov-commenter @nguyer