Update GitHub actions to build every merge to main #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Signed-off-by: Nicko Guyer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 225 225
Lines 12406 12406
=========================================
Hits 12406 12406 Continue to review full report at Codecov.
|
peterbroadhurst
approved these changes
Oct 25, 2021
Contributor
peterbroadhurst
left a comment
There was a problem hiding this comment.
Great stuff. I'll factor this into what I was doing in #285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new GitHub action to build a docker image for every merge to
main, but it is not designated as a "release" on GitHub. This allows us to use and test any commit, but won't clutter up our releases page. The image will be tagged with a date-stamped release number, and the newest build will also be tagged withhead. This means if someone wants the latest, bleeding edge build of firefly, the can just pulldocker pull ghcr.io/hyperledger/firefly:headand they will get whatever is the latest commit in `main.The images area also labeled (separate from being tagged) with the Git commit that they were built from, as well as the date and build number.
The
manifestgen.shscript also gets an update with this, allowing it to pull theheadtag for all services and create amanifest.jsonwith those images. To do this, run: