Use a single mutex, as there is a single keys map #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 99.55% 99.53% -0.03%
==========================================
Files 217 217
Lines 12181 12178 -3
==========================================
- Hits 12127 12121 -6
- Misses 40 42 +2
- Partials 14 15 +1
Continue to review full report at Codecov.
|
nguyer
approved these changes
Oct 15, 2021
Contributor
nguyer
left a comment
There was a problem hiding this comment.
I'm guessing this PR has the same drop in coverage that the other one did. Other than that, looks good.
awrichar
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254
The problem in the stack, is that we were creating separate mutexes for locking, but passing the same root map down in the config objects. So this cleans up the code to a single mutex, and makes it more clear there's a single root map.