-
Notifications
You must be signed in to change notification settings - Fork 241
Clean up Gen 1 "KAT" implementation, and update README #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Peter Broadhurst <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 214 214
Lines 11820 11820
=========================================
Hits 11820 11820 Continue to review full report at Codecov.
|
3e7ccd7 to
587518d
Compare
Signed-off-by: Peter Broadhurst <[email protected]>
587518d to
31b135d
Compare
Signed-off-by: Peter Broadhurst <[email protected]>
nguyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor suggestion and a general comment, but otherwise this is fantastic. Thank you!
| It implements a [multi-party system](#multi-party-systems) for building enterprise decentralized applications. | ||
|
|
||
| You will see enterprise focussed code in FireFly solving hard "plumbing" problems like on-chain/off-chain event sequencing and aggregation, and enough smart contract code to make the patterns possible. You will then find patterns of integration with the individual communities that are already building the deep blockchain & multi-party compute tech, like Hyperledger Fabric, Hyperledger Besu, Quorum, Corda, IPFS, Hyperledger Avalon, OpenZeppelin, NodeRED etc. | ||
| - Transaction submission and event streaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest some sort of header or sentence above here describing what this is a list of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to take this on for a next rev - there's still more to do here I think. Agree with the feedback.
| The next wave of business applications that build in a decentralized way on multi-party systems, can orchestrate data and business process flows across organizational boundaries. The integrity of the end-to-end transactions can be established throughout its lifecycle, rather than requiring complex handoff and compensation logic each time a new party performs its step. Yet the autonomy of each business and IT team is maintained in a way that could not be by pooling data and business logic in a 3rd party centralized business application. | ||
|
|
||
| ## Navigating this repo | ||
| Blockchain and other advanced cryptography technologies like zero-knowledge proofs (ZKPs), and trusted execution environments (TEEs), are the core technologies that enable this new model of cross-organizational data flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize we're just talking about multiparty systems in general here, but I worry that this will confuse people, thinking that ZKPs and TEEs are part of FireFly now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to state that they are, even though it's not in V1.0 milestone scope. There is active thinking there, and certainly there's preparatory engineering in the community.
Uh oh!
There was an error while loading. Please reload this page.