Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Oct 12, 2021

  • Remove the generation 1 KAT runtime, now that Tokens is delivered and functional parity is there in Gen 2
  • Substantial update to the README, to hopefully make the goals of the project as clear as possible, orient potential users/contributors, then get them to the right bit of the docs.

@peterbroadhurst peterbroadhurst marked this pull request as ready for review October 12, 2021 03:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #243 (d16a59e) into main (c894700) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          214       214           
  Lines        11820     11820           
=========================================
  Hits         11820     11820           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17bd391...d16a59e. Read the comment docs.

@peterbroadhurst peterbroadhurst force-pushed the readme branch 3 times, most recently from 3e7ccd7 to 587518d Compare October 12, 2021 03:53
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion and a general comment, but otherwise this is fantastic. Thank you!

It implements a [multi-party system](#multi-party-systems) for building enterprise decentralized applications.

You will see enterprise focussed code in FireFly solving hard "plumbing" problems like on-chain/off-chain event sequencing and aggregation, and enough smart contract code to make the patterns possible. You will then find patterns of integration with the individual communities that are already building the deep blockchain & multi-party compute tech, like Hyperledger Fabric, Hyperledger Besu, Quorum, Corda, IPFS, Hyperledger Avalon, OpenZeppelin, NodeRED etc.
- Transaction submission and event streaming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest some sort of header or sentence above here describing what this is a list of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to take this on for a next rev - there's still more to do here I think. Agree with the feedback.

The next wave of business applications that build in a decentralized way on multi-party systems, can orchestrate data and business process flows across organizational boundaries. The integrity of the end-to-end transactions can be established throughout its lifecycle, rather than requiring complex handoff and compensation logic each time a new party performs its step. Yet the autonomy of each business and IT team is maintained in a way that could not be by pooling data and business logic in a 3rd party centralized business application.

## Navigating this repo
Blockchain and other advanced cryptography technologies like zero-knowledge proofs (ZKPs), and trusted execution environments (TEEs), are the core technologies that enable this new model of cross-organizational data flow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize we're just talking about multiparty systems in general here, but I worry that this will confuse people, thinking that ZKPs and TEEs are part of FireFly now

Copy link
Contributor Author

@peterbroadhurst peterbroadhurst Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to state that they are, even though it's not in V1.0 milestone scope. There is active thinking there, and certainly there's preparatory engineering in the community.

@peterbroadhurst peterbroadhurst merged commit aabcb8e into hyperledger:main Oct 15, 2021
@peterbroadhurst peterbroadhurst deleted the readme branch October 15, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants