Add query support for Fabric #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <[email protected]>
awrichar
reviewed
Feb 17, 2022
test/e2e/fabric_contract_test.go
Outdated
| asset := nanoid.New() | ||
| invokeFabContract(suite.T(), suite.fabClient, "firefly", suite.chaincodeName, "org_0", "CreateAsset", []string{asset}) | ||
| assetName := nanoid.New() | ||
| // invokeFabContract(suite.T(), suite.fabClient, "firefly", suite.chaincodeName, "org_0", "CreateAsset", []string{asset}) |
Contributor
There was a problem hiding this comment.
Should this line be removed?
awrichar
approved these changes
Feb 17, 2022
Signed-off-by: Nicko Guyer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #533 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 275 275
Lines 15809 15833 +24
=========================================
+ Hits 15809 15833 +24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes query parameters on
POSTrequests to Fabconnect in favor of always using the request body and a well definedpayloadSchema