Skip to content

Fix possibility for nil access in sendloop #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix possibility for nil access in sendloop #486

merged 1 commit into from
Feb 8, 2022

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Feb 7, 2022

Fix for #485 with a bonus fix for this timing issue I'm seeing intermittently since upgrading my laptop.

time="2022-02-07T13:21:00-05:00" level=info msg="API server context cancelled - shutting down"
time="2022-02-07T13:21:00-05:00" level=info msg="API server complete"
--- FAIL: TestTLSServerSelfSignedWithClientAuth (0.13s)
    http_server_test.go:197: 
                Error Trace:    http_server_test.go:197
                Error:          Received unexpected error:
                                context deadline exceeded
                Test:           TestTLSServerSelfSignedWithClientAuth

@nguyer nguyer merged commit ec3444e into hyperledger:main Feb 8, 2022
@nguyer nguyer deleted the fix-485 branch February 8, 2022 17:13
@nguyer nguyer mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awrichar awrichar Awaiting requested review from awrichar

2 more reviewers

@nguyer nguyer nguyer approved these changes

@jimthematrix jimthematrix jimthematrix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterbroadhurst @nguyer @jimthematrix