Allow synchronous 200 response for token pool creation #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 279 282 +3
Lines 15077 15176 +99
===========================================
+ Hits 15077 15165 +88
- Misses 0 11 +11
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
The transaction ID must be present in the response to /createpool, but it is optional in the response to /activatepool (because on that flow, the TokenPool has already been initialized by the definition broadcast handler). Signed-off-by: Andrew Richardson <[email protected]>
peterbroadhurst
approved these changes
Jan 29, 2022
| @@ -0,0 +1,3 @@ | |||
| BEGIN; | |||
| ALTER TABLE tokenpool DROP COLUMN key; | |||
Contributor
There was a problem hiding this comment.
Glad to see this drop 👍
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.