Restore Transaction reference on TokenTransfer #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although transfers initiated outside of FireFly will NOT have a Transaction, it's still useful to track Transactions for those transfers initiated by FireFly. This is needed for tracking of async transfer requests, filtering transfers, etc. Partially reverts 0e654d2 Signed-off-by: Andrew Richardson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 278 278
Lines 14952 14960 +8
=========================================
+ Hits 14952 14960 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although transfers initiated outside of FireFly will NOT have a Transaction, it's
still useful to track Transactions for those transfers initiated by FireFly. This
is needed for tracking of async transfer requests, filtering transfers, etc.
Partially reverts 0e654d2