[erc20-payload] pass name and symbol to CreateTokenPool() #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Echelberger <[email protected]>
Contributor
Author
|
Tests failing due to ERC1155 connector not stripping unneeded inputs. This has been fixed in hyperledger/firefly-tokens-erc1155#54. Once release is cut in that repo, e2e should pass |
Contributor
|
Can you update |
Signed-off-by: David Echelberger <[email protected]>
awrichar
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERC20 token connector for Firefly requires that
nameandsymbolbe passed to the ERC20 token factory. This PR allows for firefly to pass these fields down to the token connector.