Skip to content

Conversation

IlyasMoutawwakil
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil IlyasMoutawwakil marked this pull request as ready for review September 2, 2025 07:15
Comment on lines +39 to +40
pip install optimum-onnx@git+https://github.com/huggingface/optimum-onnx.git
pip install .[tests]
Copy link
Member Author

@IlyasMoutawwakil IlyasMoutawwakil Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix unresolvable dependency issue
Using pip install .[onnx] results in a dependency graph where optimum@PR points to optimum-onnx@main which points at optimum@main

Copy link
Member

@Abdennacer-Badaoui Abdennacer-Badaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 Huge work!

@IlyasMoutawwakil IlyasMoutawwakil merged commit 267500e into main Sep 3, 2025
15 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the rm-ort-pipelines branch September 3, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants